Skip to content

[iDNS] Fix mermaid in architecture-overview #21296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 1, 2025
Merged

[iDNS] Fix mermaid in architecture-overview #21296

merged 1 commit into from
Apr 1, 2025

Conversation

@RebeccaTamachiro
Copy link
Contributor

@RebeccaTamachiro RebeccaTamachiro commented Apr 1, 2025

Summary

No ticket. Quick fix for an issue I noticed while working on something else.

Screenshots (optional)

Before
image

After
image

@RebeccaTamachiro RebeccaTamachiro requested a review from a team as a code owner April 1, 2025 17:26
@hyperlint-ai
Copy link
Contributor

hyperlint-ai bot commented Apr 1, 2025

Howdy and thanks for contributing to our repo. The Cloudflare team reviews new, external PRs within two (2) weeks. If it's been two weeks or longer without any movement, please tag the PR Assignees in a comment.

We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally.

PR Change Summary

Fixed issues with the mermaid diagram syntax in the architecture overview documentation.

  • Corrected syntax for DNS records in the flowchart
  • Updated diagram labels for clarity
  • Ensured consistency in the representation of DNS zones

Modified Files

  • src/content/docs/dns/internal-dns/index.mdx
How can I customize these reviews?

Check out the Hyperlint AI Reviewer docs for more information on how to customize the review.

If you just want to ignore it on this PR, you can add the hyperlint-ignore label to the PR. Future changes won't trigger a Hyperlint review.

Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add hyperlint-ignore to the PR to ignore the link check for this PR.

@RebeccaTamachiro RebeccaTamachiro enabled auto-merge (squash) April 1, 2025 17:27
@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2025

Preview URL: https://c367bc90.preview.developers.cloudflare.com
Preview Branch URL: https://rebecca-internal-dns-fix-broken-mermaid.preview.developers.cloudflare.com

Files with changes (up to 15)

Original Link Updated Link
https://developers.cloudflare.com/dns/internal-dns/ https://rebecca-internal-dns-fix-broken-mermaid.preview.developers.cloudflare.com/dns/internal-dns/

@RebeccaTamachiro RebeccaTamachiro merged commit cb717e0 into production Apr 1, 2025
11 checks passed
@RebeccaTamachiro RebeccaTamachiro deleted the rebecca/internal-dns-fix-broken-mermaid branch April 1, 2025 18:26
@github-actions github-actions bot added size/xs product:dns Issues or PRs related to DNS labels Apr 1, 2025
RebeccaTamachiro added a commit that referenced this pull request Apr 21, 2025
@RebeccaTamachiro
[iDNS] Fix mermaid reference zone example in Overview (#21296)
63a6983
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ranbel ranbel ranbel approved these changes

Assignees

No one assigned

Labels

product:dns Issues or PRs related to DNS size/xs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@RebeccaTamachiro @ranbel